Fix mimeType detection for CSV file #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicpatel
force-pushed
the
2022.3.x-fix-csv-file-upload
branch
from
394d500
to
1443290
Compare
vicpatel
commented
Apr 19, 2022
| defer func() { | ||
| // reset settings after we're done | ||
| systemService.CurrentSettings.Compose.Record.Attachments.MaxSize = 0 | ||
| systemService.CurrentSettings.Compose.Record.Attachments.Mimetypes = nil | ||
| }() | ||
|
|
||
| systemService.CurrentSettings.Compose.Record.Attachments.MaxSize = maxSizeLimit | ||
| systemService.CurrentSettings.Compose.Record.Attachments.Mimetypes = []string{ | ||
| "application/octet-stream", | ||
| } |
There was a problem hiding this comment.
Removing this; No need to add fallback allowed mime-type after updating mime-type detection func, It extracts file mime-type more accurately now.
vicpatel
force-pushed
the
2022.3.x-fix-csv-file-upload
branch
from
0ef63ae
to
8ba31ca
Compare
tjerman
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.